Log in

No account? Create an account
patches for 4.1.2 - LogJam [entries|archive|friends|userinfo]

[ website | LogJam ]
[ userinfo | livejournal userinfo ]
[ archive | journal archive ]

patches for 4.1.2 [May. 26th, 2003|02:15 pm]


First of all, I'd like to say thanks to everybody who made logjam real. I am using logjam for about a month, and found it a very nice LJ client.

I have set up a page containing unofficial logjam RPM. The problem with "official" RPM is missing %__make statement in %build section of logjam.spec file. It leads to binary with incorrect compiled-in paths to images and localization files, so neither images nor locate is available. Hope that official RPM maintainer will fix that.

There are also a few patches that worth mentioning.

All that stuff is tested by several people and proven stable. I hope that all this stuff will made its way to logjam CVS, as well as to the next version.

From: evan
2003-05-26 04:06 am (UTC)
You were correct: that compilation problem has already been fixed.

I've been intending to fix the language selection for a while, but I keep putting it off because I don't type much in languages other than English. Thanks for writing it! (Whom should I credit this to? I can't seem to find bobuk's name...)

In general, patches against CVS will be much more useful, especially for translations patches. The translation text in CVS often falls behind the text in the code.
For the translation, could you:
  1. Get LogJam from CVS
  2. copy your translation into the po/ directory
  3. cd po; make update-po
  4. test and fix the translation, and send me the updated ru_RU.po?
(Reply) (Thread)
[User Picture]From: bobuk
2003-05-26 04:36 am (UTC)
Thanks for quick answer!
My name is Grigory Bakunov :)
I make a cvs patch for you today.
Can i sent patches directly to evan(at)livejournal.com ?
(Reply) (Parent) (Thread)
From: evan
2003-05-26 10:53 am (UTC)
Yeah, that email address works.
(Reply) (Parent) (Thread)
[User Picture]From: bobuk
2003-05-26 01:39 pm (UTC)
(Reply) (Parent) (Thread)
[User Picture]From: bobuk
2003-05-26 06:21 am (UTC)
Woopsy. Little bug in current cvs, you forgot to change from "en" to conf.spelllanguage in lj.c
Index: lj.c
RCS file: /home/cvslj/logjam/src/lj.c,v
retrieving revision 1.68
diff -u -r1.68 lj.c
--- lj.c        26 May 2003 11:08:18 -0000      1.68
+++ lj.c        26 May 2003 13:16:57 -0000
@@ -315,7 +315,7 @@
                if (conf.options.usespellcheck) {
                        GError *err = NULL;
                        if (gtkspell_new_attach(GTK_TEXT_VIEW(ljw->eentry),
-                                               "en", &err) == NULL) {
+                                               conf.spell_language, &err) == NULL) {
                                                _("GtkSpell error: %s"), err->message);
(Reply) (Parent) (Thread)
From: evan
2003-05-26 10:56 am (UTC)
Oops! I fixed it.
(Reply) (Parent) (Thread)
[User Picture]From: spot
2003-05-26 09:01 am (UTC)
You managed to find a bug in the spec, then went to the trouble of creating a divergent RPM package... all without contacting the RPM maintainer? My email address is present in about twenty places in the spec.

Please be specific as to what precisely the bug is in my logjam spec. The rpms generated with that spec work for me, and others.
(Reply) (Thread)
[User Picture]From: spot
2003-05-26 10:00 am (UTC)
Looking into this in further detail, I can't see any differences between the logjam binary generated with %__make and the one done with %makeinstall... except that my compilation log is shorter.

Nevertheless, I've made the change in my rpms and uploaded new ones to http://people.redhat.com/tcallawa/logjam

I took out your lj script, because, frankly, you should be exporting your locale for yourself. It might be useful if it determined the language on the system and exported that first, so that it would work for all langs... but for just ru, its not useful for any other langs.

All the other patches were added.
(Reply) (Parent) (Thread)
[User Picture]From: k001
2003-05-26 11:59 am (UTC)



The problem with your spec file is that %makeinstall macro gives a number of variables to make command, those values are starting from BuildRoot, like, say


Probably some other variables are "harmful" too. See /usr/lib/rpm/macros for more details.

As %build section does not contain %__make (or just make), actual compiling is done in %makeinstall, which results in wrong paths to data files (specifically images and localization files). This is why I see English interface, and no picture of goat or lj user (during HTML preview).

It took me a long time to first notice, and when to find the problem. I used 'strace -eopen' and saw that logjam looks for images under some strange path :) It took me long time to find the reason (absence of %__make in %build section).

Note that %__make macros doesn't have variables pointing to BuildRoot, that is why their values are determined by configure arguments (which are correct).

I agree that my 'lj' script is kinda dirty hack and should not be included into RPM. Sure, locate should be set somewhere else (like in /etc/sysconfig/i18n or ~/.bashrc). But I have not switched to full-unicode system yet, so I use ru_RU.koi8-r locale in most apps (really, in all apps but logjam, which seems to not understand non-unicode).

I do really apologize for not contacting you before; I just had much work to do and forget that. The good thing is information is finally reached you.

(Reply) (Parent) (Thread)
[User Picture]From: spot
2003-05-26 01:45 pm (UTC)
ahh. thank you for the explanation. I learned something new today. :)
(Reply) (Parent) (Thread)