||[May. 21st, 2006|06:22 pm]
Are there any obvious difficulties in add supporting for the new location field? That is, would I be able to muck with the latest version in arch and figure out generally what needs to be done, with no re-architecting required?|
I have an extensive patch for 4.5.3 which adds, among other things, location support. I haven't submitted the patch with location support yet, but I've submitted most of the other features I've added.
I could try to generate a location-support-only patch if you want, or I can submit an updated mondo patch with ALL of my patches to 4.5.3 (location, screening, additional HTML entities, uh .... I don't remember what else, honestly, but I have a feeling there was something else).
Be advised that my complete mondo patch also re-orders several of the menus into an order I find more intuitive. You may or may not want this change.
I guess I'm okay with you trying to submit everything. Also, maybe you've already done this, but I thought it would be useful to add script execution support to the location field (like music).
Nope, I didn't do anything to support script execution, though it's a good idea.The mondo patch is here.
If you want to return the menus to the default order, you can do it just by changing the order of the menu headings in src/menu.c, since I re-ordered the menu setup to create the submenus first and then populate them separately (for precisely that reason -- to allow easy re-ordering).
I can probably generate a separate patch to do the same thing with "default" menu ordering if needed.
Great, thanks for your contributions!
I realize I'm a couple months behind here, but it appears babcom.com is nonexistant. Is there any way I could get my hands on this patch? ^^;
How would a script be able to find out your location though?
It all depends upon what you want the script to do. If your laptop has a GPS device for example, you could query it. Or your could go more abstract and simply report the hostname as the location. Or any number of other possibilities.
2006-05-22 02:02 am (UTC)
is there any way i could make it easier for you to contribute these as you develop them? i haven't had time for logjam development lately but i'm usually happy to review patches. though i know i've been slacking. :(
Well, the last several iterations before the location support, I had submitted separately. (Finding logjam_dev
helped there.) I meant to submit a patch for the location support once I'd been using it a little while and verified it was working properly, but, uh .... life got "interesting" in the Chinese sense, and I never got to it. Sorry about that.
I also probably need to maintain two separate source tree series so that I can easily produce diffs with my menu re-ordering, for my own use, and without, for public consumption.
Oops. Yeah, I should have really posted this to logjam_dev
, had I known it existed.
tags would be good.
Tags are already in the latest version.
i wonder if the latest version is in debian unstable yet?
i BET its just a view option, and i haven't set it to "on"
it's probably been there for ages and i've just been waiting for it to show up like a dork.
Yeah, it's in Debian unstable: That's what I am using.
2006-05-29 12:24 am (UTC)
Heh, I've been waiting too. Looked at the view menu, there it is. D'oh.
Do you think it should be considered a bug if (useful) new features are hidden by default?