?

Log in

No account? Create an account
Changing the way logjam creates links to other journals - LogJam [entries|archive|friends|userinfo]
LogJam

[ website | LogJam ]
[ userinfo | livejournal userinfo ]
[ archive | journal archive ]

Changing the way logjam creates links to other journals [Mar. 4th, 2003|12:40 am]
LogJam

logjam

[ademus05]
I wrote a patch to change the way logjam creates links to friends under the Make Link... menu option. With a maintainer's blessing, this change can be incorporated into the source.

This feature was added to mimic the way Semagic creates links to other journals. Any feedback?

Links to friends' pages that used to look like this:
arbitrary_text_with_link_to_logjam

would now look like this:
logjamarbitrary_text_with_link_to_logjam



diff -c src/link.c src2/link.c
*** src/link.c  Thu Nov 28 00:12:32 2002
--- src2/link.c Tue Mar  4 00:14:58 2003
***************
*** 135,141 ****
        } else if (gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(ruser))) {
                /* build a "friends" link */
                char *link;
!               link = g_strdup_printf("<a href=\"%s/users/%s\">%s</a>",
                                conf_cur_server()->url,
                                gtk_entry_get_text(GTK_ENTRY(euser)),
                                gtk_entry_get_text(GTK_ENTRY(etext)));
--- 135,145 ----
        } else if (gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(ruser))) {
                /* build a "friends" link */
                char *link;
!               link = g_strdup_printf("<a href=\"%s/userinfo.bml?user=%s\"><img alt=\"%s\" height=\"17\" src=\"%s/img/userinfo.gif\" border=\"0\" width=\"17\"
align=\"absmiddle\"></a><b><a href=\"%s/users/%s/\">%s</a></b>",
!                               conf_cur_server()->url,
!                               gtk_entry_get_text(GTK_ENTRY(euser)),
!                               gtk_entry_get_text(GTK_ENTRY(euser)),
!                               conf_cur_server()->url,
                                conf_cur_server()->url,
                                gtk_entry_get_text(GTK_ENTRY(euser)),
                                gtk_entry_get_text(GTK_ENTRY(etext)));
LinkReply

Comments:
[User Picture]From: abiku
2003-03-03 10:55 pm (UTC)
Personally, I wish this concept had never been introduced to LJ at all. I hate it when familiar interfaces are changed so they're no longer what they appear. It defeats the purpose of the <lj user> tag, in my opinion.

When I click on abikuademus05, I expect to go to ademus05's journal, not mine.

From a usability standpoint, this is behavior I wish LJ wouldn't encourage.
(Reply) (Thread)
[User Picture]From: erebrandir
2003-03-03 11:12 pm (UTC)
I agree. The user icon is supposed to indicate that the following link is somebody's username. Adding arbitrary text is just confusing. If you want the link to say something besides the username, then you don't need to be using the user icon.
(Reply) (Parent) (Thread)
[User Picture]From: brad
2003-03-03 11:42 pm (UTC)
I don't encourage it. (And I'll bug evan not to take this patch) But... I can't control what Semagic does. :-/
(Reply) (Parent) (Thread)
[User Picture]From: abiku
2003-03-03 11:46 pm (UTC)
True, true. I'm getting tired, so my wording was a little off. I mostly meant I wish it wouldn't be encouraged ON LiveJournal, rather than BY them/you. Sorry 'bout that.
(Reply) (Parent) (Thread)
From: evan
2003-03-04 09:16 am (UTC)
I agree.
(Reply) (Parent) (Thread)
[User Picture]From: ademus05
2003-03-04 02:45 pm (UTC)

Re:

its less about arbitrary text and the ability to provide information as to who the person is. For example, In stead of saying "I went out tonight with my roommate hawkeyemi who's name is brock," I can say "I went out with hawkeyemiBrock last night." I have friends who used this feature all the time, and I added it b/c I got tired of going to perl script to generate link code. I think its a great way to link to other people's journals without having to explain who has what user name.

I think the chorus has spoken otherwise, though. :) oh well, c'est la vie.
(Reply) (Parent) (Thread)
[User Picture]From: damnitnicole
2003-03-29 12:28 am (UTC)
Damnit, I just went through your calendar to find which client you did this for, and now I find out I'll have to put it in myself if I get Logjam?

Oh well... I guess I just won't use a client when I update from Linux. There's really no reason to without that feature, for me.
(Reply) (Thread)
[User Picture]From: ademus05
2003-03-31 10:39 pm (UTC)

Re:

tell you what, i'll make you either an rpm or a deb so you can easily get this feature. Just let me know when you get linux working.

what flavor of linux?
(Reply) (Parent) (Thread)
[User Picture]From: damnitnicole
2003-03-31 11:21 pm (UTC)

Re:

We're using Mandrake. Just changed to 9.1.

Everything else you said: what?
(Reply) (Parent) (Thread)
From: (Anonymous)
2003-11-18 09:34 am (UTC)

buy xanax

Great discussion. I thought I would share this link as well.
www.buy-xanax-vicodin.com
(Reply) (Thread)